Skip to content

Move from circleci to GitHub completely#177

Merged
michal-granec merged 2 commits intomasterfrom
move-from-circleci-to-github-completely
Nov 19, 2025
Merged

Move from circleci to GitHub completely#177
michal-granec merged 2 commits intomasterfrom
move-from-circleci-to-github-completely

Conversation

@michal-granec
Copy link
Contributor

For: https://github.com/fetlife/fetlife-web/issues/35323

This PR finalizes our complete move away from CircleCI.

Changes:

  • Add Ruby version matrix
  • store test results
  • Fix test not running on PR
  • Remove CircleCI configuration

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR completes the migration from CircleCI to GitHub Actions for CI/CD. It removes the CircleCI configuration entirely and enhances the GitHub Actions workflow with a Ruby version matrix, test result artifacts, and proper PR trigger configuration.

Key Changes:

  • Implements a Ruby version matrix (2.4 through 3.3) for comprehensive testing across multiple Ruby versions
  • Adds test result artifact upload with JUnit XML format for better test reporting
  • Fixes the pull_request trigger to run on all PRs regardless of target branch
  • Removes the CircleCI configuration file completely

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/test.yml Enhanced with Ruby version matrix (2.4-3.3), test result artifacts, and corrected PR trigger configuration
README.md Updated CI badge from CircleCI to GitHub Actions
.circleci/config.yml Removed as part of complete migration to GitHub Actions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@michal-granec michal-granec merged commit 5ba5fc6 into master Nov 19, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants