Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header in all-nodes view shorter on small screens #18

Closed
wants to merge 1 commit into from

Conversation

rubo77
Copy link
Contributor

@rubo77 rubo77 commented Dec 29, 2015

This will change the label on top of the list for all nodes to just the first Letter "U" for "Uptime" and "C" for "Clients"

@tcatm
Copy link

tcatm commented Dec 29, 2015

I don't really like this patch. It adds a config.json for no apparent reason and it hardcodes the columns used within Javascript to those in CSS.

@tcatm tcatm closed this Dec 29, 2015
@rubo77
Copy link
Contributor Author

rubo77 commented Dec 29, 2015

sure, the config.json was a mistake.

I thought about how to solve the issue to shorten the table headers on small screens with just CSS, which I would prefer, because it takes action when you resize the screen.

If we would like to use the first letter of each column without hardcoding, We would have to use javascript and a kid of resize-detection to change it on the fly when resizing the screen. Would that be a better solution?

Or I just got another Idea:
We could turn the labels by 90° on narrow screens

@jplitza
Copy link
Member

jplitza commented Jan 1, 2016

Only showing the first letter isn't that hard, rotating the titles is harder I think: https://jsfiddle.net/o0dz6ufu/

@tcatm
Copy link

tcatm commented Jan 1, 2016

Which resolutions and screensizes are affected by this anyway?

@rubo77
Copy link
Contributor Author

rubo77 commented Jan 3, 2016

Te labels don't fit on 320px with phone screens

jplitzas solution is working nice (with th:first-letter, th:first-child)

I also already solved rotating here. #19

MPW1412 pushed a commit to FreiFunkMuenster/meshviewer that referenced this pull request Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants