Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated examples #7

Merged
merged 11 commits into from
Jun 14, 2024
Merged

Updated examples #7

merged 11 commits into from
Jun 14, 2024

Conversation

vkobinski
Copy link
Collaborator

No description provided.

@vkobinski vkobinski requested a review from steinerkelvin June 12, 2024 22:23
examples/tree.py Outdated
Comment on lines 4 to 15
@dataclass
class Leaf:
value: u24


@dataclass
class Node:
left: 'Tree'
right: 'Tree'


Tree = Node | Leaf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep the expected code that we'll have working in the future commented

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the old example works properly.

Comment on lines 11 to 14
if __name__ == "__main__":
translated_simple = bjit(simple)
print(simple())
print(translated_simple())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not that relevant, but open an issue to track implementing being able to do this.
I suspect there is something weird going on anyway for this to not work.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@vkobinski vkobinski requested a review from steinerkelvin June 13, 2024 20:26
@steinerkelvin steinerkelvin merged commit 4bfc867 into fglab-tech:master Jun 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants