Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port deprecated KDE functionality #71

Merged
merged 5 commits into from
Apr 27, 2024

Conversation

alexfikl
Copy link
Contributor

This should also get rid of the few deprecation warnings from the KDE side. Hopefully the CI will confirm.

@alexfikl alexfikl marked this pull request as draft April 27, 2024 18:14
@alexfikl
Copy link
Contributor Author

alexfikl commented Apr 27, 2024

The KMessageBox deprecation was apparently introduced in 5.100, so it's not supported on the CI. Will have to add a guard around it.

EDIT: This seems to be working as expected now and the CI doesn't show any more deprecation warnings!

@alexfikl alexfikl force-pushed the port-kde-methods branch 2 times, most recently from 70602ba to 3700cf1 Compare April 27, 2024 19:01
@alexfikl alexfikl marked this pull request as ready for review April 27, 2024 19:22
@jfmcarreira jfmcarreira merged commit 9ec495a into fhackenberger:master Apr 27, 2024
4 checks passed
@alexfikl alexfikl deleted the port-kde-methods branch April 27, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants