Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing colons to dashes in titles #113

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

cansavvy
Copy link
Contributor

Purpose/implementation Section

What changes are being implemented in this Pull Request?

Leanpub doesn't like colons (it legit ignores files with colons in the name). So I'm replacing colons putting dashes for all titles here.

Copy link
Contributor

github-actions bot commented Nov 14, 2023

No spelling errors! 🎉
Comment updated at 2023-11-15 with changes from 10c16d5

Copy link
Contributor

github-actions bot commented Nov 14, 2023

⚠️ broken urls ⚠️
There are broken urls that need to be addressed. Read this guide for more info.
Download the errors here.
Comment updated at 2023-11-15 with changes from 10c16d5

@cansavvy cansavvy marked this pull request as ready for review November 14, 2023 15:53
Copy link
Contributor

github-actions bot commented Nov 14, 2023

Re-rendered previews from the latest commit:

Updated at 2023-11-15 with changes from 10c16d5

README.md Outdated
@@ -6,7 +6,7 @@ This course was created from [this GitHub template](https://github.com/jhudsl/OT

You can see the rendered course material [here](https://hutchdatascience.org/AI_for_software/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we change this one too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Good catch.

README.md Outdated
@@ -6,7 +6,7 @@ This course was created from [this GitHub template](https://github.com/jhudsl/OT

You can see the rendered course material [here](https://hutchdatascience.org/AI_for_software/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can see the rendered course material [here](https://hutchdatascience.org/AI_for_software/).
You can see the rendered course material [here](https://hutchdatascience.org/AI_for_Efficient_Programming/).

README.md Outdated Show resolved Hide resolved
@carriewright11
Copy link
Contributor

I think maybe the ethics chapter might still have some? The changes look good though.

@ehumph
Copy link
Collaborator

ehumph commented Nov 20, 2023

Yes, it looks like the only remaining colon is for the Combating Bias in LLMs video title. LGTM, and thank you, @cansavvy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants