-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
color palettes part of package #1
Conversation
Sorry for the delay getting to this @kweav - You also need to have .rda versions of the palettes to test this package works. |
no need to apologize! Sorry I didn't push those. I'll try to add them right now |
@avahoffman they should be there now hopefully |
@kweav great! Testing now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Only thing I'd add is a few items to the readme:
- Install steps - could use below based on https://github.com/mccarthy-m-g/sunsets/blob/main/README.md:
## Installation
You can install the development version of sunsets from
[GitHub](https://github.com/) with:
``` r
# install.packages("devtools")
devtools::install_github("mccarthy-m-g/sunsets")
```
## Usage
``` r
library(sunsets)
#> Loading required package: palettes
```
sunsets comes with a set of 2 discrete colour palettes, and 5 sequential
colour palettes, which can be accessed from the following R objects:
- `sunset_palettes_discrete` for discrete palettes
- `sunset_palettes_sequential` for sequential palettes
- `sunset_palettes` for all palettes
To preview the palettes in the console simply print them:
``` r
sunset_palettes_discrete
```
- perhaps one or two examples of how you'd use this package with ggplot2. Could be the same data as here:
https://mccarthy-m-g.github.io/palettes/articles/ggplot2.html
@avahoffman I think those README suggestions might be in PR #2. Let me know if you'd like changes to what's there please |
Thanks for pointing that out. Let's merge this and then take a look at the rendered readme on #2 ! |
Set up some color palettes based on the AnVIL style guide, this walkthrough, and Howard's example hutchplot package