Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/following routes #103

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

linus-skold
Copy link

This change fixes the paths that has been changed and resolves an issue where you'd receive 302 Temporarily Moved by following the redirect.

@origooo
Copy link

origooo commented May 15, 2024

Any thoughts on merging this pull request? It seems the new paths are required.

Btw @linus-skold, haven't you missed those path parts {0} etc in SEARCH_PATH and TRANSACTIONS_PATH? And, are all the new/updated paths used in any API methods?

@linus-skold
Copy link
Author

@origooo good catch with the path parts, completely overlooked them when copying the paths from #99 (comment)
Added them.

That's a really great question, if they are completely new, new constant, then they are not in use by anything but there's no harm in adding them to increase visibility of them if something needs to use it.

The updated ones are still in use as far as I know, and is still in use the same way as before.
Any issue connected to them doing something else should probably be addressed, but in that case we should create new issues and link them here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants