MGMT-882 Add base URL including protocol to config map#508
MGMT-882 Add base URL including protocol to config map#508empovit wants to merge 1 commit intofilanov:masterfrom empovit:vemporop/MGMT-882
Conversation
|
Where are these environment variables actually used? |
|
@ronniel1 other PRs are coming. I want to avoid a chicken-and-egg problem, so making changes incrementally. My reasoning is make the variable available, change A to use it. B can still use the old ones. Remove when everybody uses the new variable. This is probably because I can't estimate the impact yet. |
| type InstructionConfig struct { | ||
| InventoryURL string `envconfig:"INVENTORY_URL" default:"10.35.59.36"` | ||
| InventoryPort string `envconfig:"INVENTORY_PORT" default:"30485"` | ||
| InventoryBaseUrl string `envconfig:"INVENTORY_BASE_URL" default:"http://10.35.59.36:30485"` |
There was a problem hiding this comment.
Default is not needed - it's incorrect anyway.
There was a problem hiding this comment.
I was trying to keep the existing functionality. Do you want me to remove it?
There was a problem hiding this comment.
i was talking about the default values, once the agent and test infra ready to this change you can remove those as well.
| ReleaseImage string `envconfig:"OPENSHIFT_INSTALL_RELEASE_IMAGE" default:"quay.io/openshift-release-dev/ocp-release@sha256:eab93b4591699a5a4ff50ad3517892653f04fb840127895bb3609b3cc68f98f3"` | ||
| InventoryURL string `envconfig:"INVENTORY_URL" default:"10.35.59.36"` | ||
| InventoryPort string `envconfig:"INVENTORY_PORT" default:"30485"` | ||
| InventoryBaseURL string `envconfig:"INVENTORY_BASE_URL" default:"http://10.35.59.36:30485"` |
There was a problem hiding this comment.
Default is not needed - it's incorrect anyway.
|
@YuviGold I'm not sure I understand your comment. The host and port parameters have been consolidated into a single URL parameter, with the default value of http://10.35.59.36:30485 |
|
@empovit it will need test-infra-change too |
|
@tsorya yes, thanks for reminding me! The commit is ready, I'm waiting with a PR :) empovit/assisted-test-infra@3c3cccc |
5 participants
No description provided.