Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-data-transfer to v2.0.0-rc1 #15

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Conversation

kylehuntsman
Copy link
Contributor

@kylehuntsman kylehuntsman commented Jan 4, 2023

Updates the filecoin-project/go-data-transfer dependency to v2.0.0-rc1 following a similar but unmerged PR for the same in application-research/filclient. That PR was blocked due to it's Lotus dependencies. Lassie is no longer dependent on Lotus and can therefore update it's dependencies without being blocked.

Modules intentionally changed:
Removed github.com/filecoin-project/go-data-transfer v1.15.2
Added github.com/filecoin-project/go-data-transfer/v2 v2.0.0-rc1
Added github.com/filecoin-project/go-fil-markets v1.24.3-0.20221014045531-68279a837f6a

Resolves issue #3

@kylehuntsman kylehuntsman linked an issue Jan 4, 2023 that may be closed by this pull request
Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I think -- the changes to retrieval code were largely from my side right?

@kylehuntsman
Copy link
Contributor Author

kylehuntsman commented Jan 5, 2023

LGTM I think -- the changes to retrieval code were largely from my side right?

Yeah, I took everything related to the VoucherType and BindNode.RegisterType stuff. I kept all of Lassie's go-state-types usage since the original PR still used the Lotus dependencies. The structure of it all was relatively the same except for the changes that required VoucherTypes.

@hannahhoward
Copy link
Collaborator

Sounds good

@kylehuntsman kylehuntsman merged commit b3a8875 into main Jan 6, 2023
@kylehuntsman kylehuntsman deleted the chore/datatransfer-v2 branch January 6, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to go-data-transfer v2
2 participants