fix: measure "connect time" per-peer for peer scoring #431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, the "start" is the same for all peers, regardless of whether they come in from the indexer at different times; this makes it strictly local to the peer so we can score it accordingly.
I don't think this should make a material difference if we're getting the graphsync and http peers in an initial batch from the indexer. The current start-time calculation begins from before we even get candidates back, but they are all the same start. The actual value for this only matters for scoring candidates so mostly it's the relative value that matters. What we intended for this, however, was that if this number is
0
or close to it, it means we're already connected to the peer so we should try them first.TransportProtocol
is a public interface so this would technically be a breaking change.