Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use go-fixtureplate to make unixfs fixtures #436

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Sep 26, 2023

Depends on release of https://github.com/ipld/go-fixtureplate and merge of ipfs/go-unixfsnode#53

This is not a huge value-add other than being a bit more explicit about what we're testing. I recently simplified this code anyway, this takes it a few steps more and uses the go-fixtureplate DSL to generate the synthetic UnixFS data. It's been useful in getting go-fixtureplate working nicely and the API cleaned up.

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

Merging #436 (a71241d) into main (a9ecb49) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
- Coverage   76.60%   76.53%   -0.08%     
==========================================
  Files          85       85              
  Lines        6387     6387              
==========================================
- Hits         4893     4888       -5     
- Misses       1242     1245       +3     
- Partials      252      254       +2     
Files Coverage Δ
pkg/internal/itest/util.go 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

@rvagg
Copy link
Member Author

rvagg commented Sep 27, 2023

updated other deps while in there because we have a new storetheindex release that we can jump to from the untagged one we've been on; so this updates libipni and graphsync too.

@rvagg rvagg marked this pull request as ready for review September 27, 2023 02:09
@rvagg rvagg merged commit d9e0de8 into main Sep 27, 2023
9 checks passed
@rvagg rvagg deleted the rvagg/fixtureplate branch September 27, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants