docs: update README's go example, link fixes #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #455 +/- ##
==========================================
+ Coverage 75.67% 75.69% +0.01%
==========================================
Files 87 87
Lines 6657 6657
==========================================
+ Hits 5038 5039 +1
+ Misses 1337 1335 -2
- Partials 282 283 +1 |
gammazero
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This simply updates the README.
Details
The go example was using lassie v0.17.0 and
types.DagScopeAll, which was dropped in v0.18.0 and now lives attrustlessutils.DagScopeAll. The behavior forlassie.Fetchalso changed so that it cannot exceptniloptions since these are variadic. Also, a couple of links were broken.