deps: downgrade boxo to working commit #460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ugh, this doesn't work because of the added another commit to downgrade more but it's ended up as basically a revert of #456, which isn't ideal |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
==========================================
- Coverage 75.72% 75.61% -0.11%
==========================================
Files 87 87
Lines 6657 6657
==========================================
- Hits 5041 5034 -7
- Misses 1335 1338 +3
- Partials 281 285 +4 |
gammazero
approved these changes
Nov 28, 2023
|
It would be nice to just fix bitswap. Added my voice to the original issue here |
|
This PR is no longer needed. Using new boxo branch (feat/lassie-fork-boxo-v0.19.0) with bitswap patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #459
I think this is probably not a big deal because the only direct use of storetheindex we have here is to pull in the e2e test runner (and when running the e2e test it grabs HEAD). Not sure if there's anything that transitives are using that might be important to have this upgrade for though. @gammazero ?