Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pubsub): Switch to a last-seen cache strategy #12389

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(pubsub): Switch to a last-seen cache strategy #12389

wants to merge 1 commit into from

Commits on Aug 14, 2024

  1. fix(pubsub): Switch to a last-seen cache strategy 

    We were using the default first-seen strategy which means we'd loop
messages every 2 minutes (when they expire from the cache). This new
strategy keeps the message in the cache until we haven't seen it for 2
minutes, ensuring that it eventually drops off the network (with high
likelihood).

The correct fix is message expiration:
libp2p/go-libp2p-pubsub#573, but that requires
deeper protocol changes.
    @Stebalien
    Stebalien committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    d8e22b7 View commit details
    Browse the repository at this point in the history