chore(deps): update go-state-types, adapt to QAP API changes #12445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #12369 deprecate StateMinerInitialPledgeCollateral since it only accounts for deals in PCI, which aren't present in a DDO world
ribasushi
reviewed
Sep 11, 2024
I can cut GST v0.15.0-rc1 to make the GST update here a bit cleaner. However, since there is still some time before we start the Lotus nv24 train, I suggest leaving this unmerged until we have decided if we want to ship a Lotus minor version with the indexing revamp (pending discussion we will have in a weeks time or so), to make the "cut release from master" a bit easier. |
rvagg
force-pushed
the
rvagg/StateMinerInitialPledgeForSector
branch
3 times, most recently
from
c55777c
to
b714b82
Compare
rvagg
force-pushed
the
rvagg/StateMinerInitialPledgeForSector
branch
4 times, most recently
from
f7244dd
to
910288c
Compare
Base automatically changed from
rvagg/StateMinerInitialPledgeForSector
to
master
September 25, 2024 06:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates go-state-types and incorporates filecoin-project/go-state-types#308 which removes "deal weight" entirely from QAP calculation since it's unnecessary. So, we inherit a signature change here for
QAPowerForWeightwhich drops the deal weight argument.This is on top of #12384 because it touches pledge calculation too. I'll leave this as draft until that merges. We also don't have a tagged gst with this change, and it might be best to leave this commit until @rjan90 cuts a second prerelease and pulls that in for nv24.