feat(api): chain export v2 support #13395
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rjan90 This pr needs a changelog, I will add it later |
tediou5
removed
the
skip/changelog
tediou5
force-pushed
the
feat/chain-export-v2-support
branch
from
3742e10 to
9adf222
Compare
|
I did a manual test of import and export on cali-network with the latest snapshot and it works fine |
rvagg
reviewed
Oct 20, 2025
rvagg
reviewed
Oct 20, 2025
rvagg
reviewed
Oct 20, 2025
| // If oldmsgskip is set, messages from before the requested roots are also not included. | ||
| ChainExport(ctx context.Context, nroots abi.ChainEpoch, oldmsgskip bool, tsk types.TipSetKey) (<-chan []byte, error) //perm:read | ||
| // | ||
| ChainExport(ctx context.Context, nroots abi.ChainEpoch, oldmsgskip bool, tsk types.TipSetKey, version uint64) (<-chan []byte, error) //perm:read |
There was a problem hiding this comment.
this is going to be an annoyingly breaking change .. of the type we've kind of agreed to avoid if at all possible in v1
There was a problem hiding this comment.
Yes, this is a change that needs careful consideration, so I'm putting it in a separate PR now.
We will need it eventually, and using lotus-shed to export is not always convenient (need to take the node offline). But I agree that we can discuss it more. I just submitted it first so that you can see the diff
Co-authored-by: Rod Vagg <rod@vagg.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Follow-up to #13282
Proposed Changes
Add a
versionparameters to the ChainExport API to specify the version of the exported snapshot (1 or 2).The lotus chain cmd exports the V2Snapshot by default. Use the
--version 1option to export a V1 snapshot.Additional Info
Checklist
Before you mark the PR ready for review, please make sure that: