Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch over to self hosted CI #1764

Merged
merged 7 commits into from
Oct 2, 2024
Merged

Switch over to self hosted CI #1764

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5c30611
feat: start converting some CI to self-hosted
cryptonemo Sep 30, 2024
b1b00f3
feat: attempt to convert remaining tests to self-hosted
cryptonemo Sep 30, 2024
7b30261
feat: fix forgotten update
cryptonemo Sep 30, 2024
062730e
feat: put back in required check out
cryptonemo Sep 30, 2024
e4009f1
kick CI
cryptonemo Oct 1, 2024
0616be7
feat: only run CI on push, not both PR and push, which can cause GPU …
cryptonemo Oct 1, 2024
70b6e6a
fix: play with parallelism to avoid conflicts on runners
cryptonemo Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 27 additions & 68 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: CI

on: [pull_request, push]
#on: [pull_request, push]
on: [push]

# Cancel a job if there's a new on on the same branch started.
# Based on https://stackoverflow.com/questions/58895283/stop-already-running-workflow-job-in-github-actions/67223051#67223051
Expand All @@ -17,25 +18,23 @@ env:

jobs:
check_clippy:
runs-on: ubuntu-24.04
runs-on: self-hosted
name: Clippy
steps:
- uses: actions/checkout@v4
- name: Install required packages
run: sudo apt install --no-install-recommends --yes libhwloc-dev ocl-icd-opencl-dev
- name: Run cargo clippy
run: cargo clippy --all-targets --workspace -- -D warnings

check_fmt:
runs-on: ubuntu-24.04
runs-on: self-hosted
name: Checking fmt
steps:
- uses: actions/checkout@v4
- name: Run cargo fmt
run: cargo fmt --all -- --check

test_release:
runs-on: ubuntu-24.04
runs-on: self-hosted
name: Test in release mode
strategy:
matrix:
Expand All @@ -45,96 +44,56 @@ jobs:
FIL_PROOFS_USE_MULTICORE_SDR: true
steps:
- uses: actions/checkout@v4
- name: Install required packages
run: sudo apt install --no-install-recommends --yes libhwloc-dev ocl-icd-opencl-dev

- name: Download the proof params
uses: ./.github/actions/proof-params-download
with:
github-token: ${{ secrets.GITHUB_TOKEN }}

- name: Run usual tests in release profile
run: cargo test --verbose --release --workspace --all-targets ${{ matrix.cargo-args }} -- --nocapture
- name: Run isolated PoRep tests in release profile
# Getting the cores does not work on GitHub Actions, hence skip that
# specific test.
run: cargo test --release -p storage-proofs-porep --features isolated-testing ${{ matrix.cargo-args }} -- --nocapture --skip stacked::vanilla::cores::tests::test_checkout_cores
run: cargo test --release -p storage-proofs-porep --features isolated-testing ${{ matrix.cargo-args }} -- --nocapture --test-threads=1
- name: Run isolated update tests in release profile
# Some `storage-proofs-update` tests need to run sequentially due to
# their high memory usage.
run: cargo test --release -p storage-proofs-update --features isolated-testing ${{ matrix.cargo-args }} -- --nocapture --test-threads=1
run: cargo test --release -p storage-proofs-update --features isolated-testing ${{ matrix.cargo-args }} -- --nocapture

test_ignored_release:
runs-on: ubuntu-24.04
runs-on: self-hosted
name: Test ignored in release mode
steps:
- uses: actions/checkout@v4
- name: Install required packages
run: sudo apt install --no-install-recommends --yes libhwloc-dev ocl-icd-opencl-dev

- name: Download the proof params
uses: ./.github/actions/proof-params-download
with:
github-token: ${{ secrets.GITHUB_TOKEN }}

- name: Test ignored in release profile
run: cargo test --release --workspace -- ignored --nocapture

test_no_default_features:
runs-on: ubuntu-24.04
runs-on: self-hosted
name: Test without default features
steps:
- uses: actions/checkout@v4
- name: Install required packages
run: sudo apt install --no-install-recommends --yes libhwloc-dev ocl-icd-opencl-dev

- name: Download the proof params
uses: ./.github/actions/proof-params-download
with:
github-token: ${{ secrets.GITHUB_TOKEN }}

- name: Test ignored in release profile
run: cargo test --release --workspace --no-default-features

build_gpu:
runs-on: ubuntu-24.04
runs-on: self-hosted
name: Build with various GPU support enabled
steps:
- uses: actions/checkout@v4
- name: Install required packages
run: sudo apt install --no-install-recommends --yes libhwloc-dev nvidia-cuda-toolkit ocl-icd-opencl-dev

- name: Build with `cuda` and `opencl` features enabled
run: cargo build --workspace --features cuda,opencl
- name: Build with `cuda-supraseal` feature enabled
run: CC=gcc-12 CXX=g++-12 NVCC_PREPEND_FLAGS='-ccbin /usr/bin/g++-12' cargo build --workspace --no-default-features --features cuda-supraseal

# Commented out until we run it on hardware with actual GPUs.
#test_gpu:
# runs-on: ubuntu-24.04
# name: Test on GPUs
# strategy:
# matrix:
# test-args: ['', '--ignored']
# env:
# FIL_PROOFS_USE_GPU_COLUMN_BUILDER: true
# FIL_PROOFS_USE_GPU_TREE_BUILDER: true
# BELLMAN_CUDA_NVCC_ARGS: --fatbin --gpu-architecture=sm_75 --generate-code=arch=compute_75,code=sm_75
# NEPTUNE_CUDA_NVCC_ARGS: --fatbin --gpu-architecture=sm_75 --generate-code=arch=compute_75,code=sm_75
# steps:
# - uses: actions/checkout@v4
# - name: Install required packages
# run: sudo apt install --no-install-recommends --yes libhwloc-dev nvidia-cuda-toolkit ocl-icd-opencl-dev
#
# - name: Download the proof params
# uses: ./.github/actions/proof-params-download
# with:
# github-token: ${{ secrets.GITHUB_TOKEN }}
#
# - name: Test with CUDA
# run: cargo test --verbose --release --workspace --features cuda -- --nocapture ${{ matrix.test-args }}
# - name: Test with `cuda-supraseal`
# run: CC=gcc-12 CXX=g++-12 NVCC_PREPEND_FLAGS='-ccbin /usr/bin/g++-12' cargo test -p filecoin-proofs --release --no-default-features --features cuda-supraseal -- --nocapture --test-threads=1 ${{ matrix.test-args }}
test_gpu:
runs-on: self-hosted
name: Test on GPUs
strategy:
matrix:
test-args: ['', '--ignored']
env:
FIL_PROOFS_USE_GPU_COLUMN_BUILDER: true
FIL_PROOFS_USE_GPU_TREE_BUILDER: true
BELLMAN_CUDA_NVCC_ARGS: --fatbin --gpu-architecture=sm_75 --generate-code=arch=compute_75,code=sm_75
NEPTUNE_CUDA_NVCC_ARGS: --fatbin --gpu-architecture=sm_75 --generate-code=arch=compute_75,code=sm_75
steps:
- uses: actions/checkout@v4
- name: Test with CUDA
run: cargo test --verbose --release --workspace --features cuda -- --nocapture ${{ matrix.test-args }} -- --test-threads=1
- name: Test with `cuda-supraseal`
run: CC=gcc-12 CXX=g++-12 NVCC_PREPEND_FLAGS='-ccbin /usr/bin/g++-12' cargo test -p filecoin-proofs --release --no-default-features --features cuda-supraseal -- --nocapture --test-threads=1 ${{ matrix.test-args }}

test_macos:
runs-on: macos-latest
Expand Down