This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
Divide once when calculating qa power #1493
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1493 +/- ##
======================================
Coverage 71.4% 71.4%
======================================
Files 72 72
Lines 8546 8546
======================================
Hits 6109 6109
Misses 1553 1553
Partials 884 884 |
|
From @Stebalien this might actually need a migration over partition state to be safe. Investigating... |
|
This needs a migration for safety. Closing down for now and removing from v14 scope. Putting migration ideas in issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1250
This is already well tested in miner/policy_test.go
TestQuality. The high value of SectorQualityPrecision seems to have kept any error from creeping in to the computation, at least in test cases.