Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the onion integration config #464

Closed
wants to merge 30 commits into from
Closed

Add the onion integration config #464

wants to merge 30 commits into from

Conversation

joaosa
Copy link
Contributor

@joaosa joaosa commented Aug 7, 2023

Just adds the boilerplate to the main repo

@guanzo
Copy link
Collaborator

guanzo commented Aug 7, 2023

actually, i kind of want to move shim.Dockerfile and shim_start.sh to be inside the onion dir because they're only used in that context and i'd rather not have them appear in the root dir.

@@ -55,7 +55,7 @@ setTimeout(async function () {
}, 500);

const server = http.createServer(app);
server.listen(PORT, "127.0.0.1", async () => {
server.listen(PORT, "0.0.0.0", async () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure if this change is ok to merge. any concerns?

@joaosa
Copy link
Contributor Author

joaosa commented Mar 13, 2024

closing this as it no longer matters

@joaosa joaosa closed this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants