Skip to content

Fix: Added conditional checking for RaiDrive network path #17664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Added conditional checking for RaiDrive network path #17664

wants to merge 1 commit into from

Conversation

NicholasChin28
Copy link
Contributor

@NicholasChin28 NicholasChin28 commented Sep 20, 2025 •
edited
Loading

Resolved / Related Issues

Steps used to test these changes

  1. Download and install RaiDrive client application
  2. Configure RaiDrive to mount an SFTP server connection via the RaiDrive GUI client
  3. Verify the SFTP drive appears in Windows File Explorer as a network location
image
  1. Attempt to access the RaiDrive SFTP drive using the Files application
  2. Upon step debugging through AuthenticateNetworkShare function, observe that
    RaiDrive SFTP paths follow the format \RaiDrive-{username}{drive-custom-name}\
image image
  1. Notice that WNetAddConnection3W fails when attempting to resolve the RaiDrive
    remoteName with either ERROR_BAD_NET_NAME or ERROR_NO_NET_OR_BAD_PATH
image

  1. After applying the fix, successfully access RaiDrive SFTP drives through Files
    application without errors

  2. Checked with SSHFS to test behavior.

image image image
  1. SSHFS connecting to a SFTP server seems fine as it does prompt user to key in credentials and after inputting details the folder is accessible.

@NicholasChin28
Added conditional checking for RaiDrive drive path
31890bc 
- RaiDrive seems to use a custom UNC path with the format of \\RaiDrive-{user}\{drive-custom-name}
@NicholasChin28 NicholasChin28 mentioned this pull request Sep 20, 2025
Open
@yaira2 yaira2 changed the title Added conditional checking for RaiDrive network path Fix: Added conditional checking for RaiDrive network path Sep 21, 2025
yaira2
yaira2 reviewed Sep 21, 2025
View reviewed changes
src/Files.App/Services/Storage/StorageNetworkService.cs
// Skip authentication for RaiDrive virtual shares
// RaiDrive creates virtual UNC paths that don't work with Windows networking APIs
// Format is \\RaiDrive-{user}\{drive-custom-name}\
if (path.StartsWith(@"\\RaiDrive-", StringComparison.OrdinalIgnoreCase))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we create a constant for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs - code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Opening network drive from RaiDrive shows ERROR_BAD_NET_NAME
2 participants
@NicholasChin28 @yaira2