Extended mock functionality and support new AWS builder#8
Open
diversit wants to merge 10 commits intofindify:masterfrom
Open
Extended mock functionality and support new AWS builder#8diversit wants to merge 10 commits intofindify:masterfrom
diversit wants to merge 10 commits intofindify:masterfrom
Conversation
Updated sbt to 0.13.15. Set version to 0.3.3-SNAPSHOT.
Also did some changes to make it inline with S3Mock (start now returns ServerBinding, shutdown renamed to stop, takes implicit system argument).
… provides versions for Scala 2.11 and 2.12.
|
Any chance of at least merging this, if you you are no longer supporting the project? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for creating SQSMock!
While using it, I missed some features which I added. E.g. ListQueues, GetQueueUrl, GetQueueAttributes, DeleteMessageBatch, DeleteQueue.
I also updated some dependencies and added 2.11 and 2.12 cross build since I also wanted to use it for AWScala where I also added quite some improvements.
The latest AWS Java library now require a builder to construct clients. Updated the SQSStartStop trait to use the new builder to construct an SQS client.
I hope you consider to merge these changes in the next release of SQSMock.
Best regards,
Joost