Skip to content
This repository has been archived by the owner on May 28, 2024. It is now read-only.

public DID as URL #515

Merged
merged 9 commits into from
Mar 7, 2024
Merged

public DID as URL #515

merged 9 commits into from
Mar 7, 2024

Conversation

lainio
Copy link
Contributor

@lainio lainio commented Mar 7, 2024

  • not used args removed
  • readability with assert and try.Out
  • refactor CreateInvitation for internal use too, outside gRPC
  • implement http endpoint to get dynamic-invitation
  • error case test for pub DID url
  • use GET query for pub DID case
  • fix that memory DB runs answer /ready endpoint
  • query params renamed, refactored

@github-actions github-actions bot added the dev label Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 47.61905% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 76.47%. Comparing base (51232ee) to head (bc5e086).

Files Patch % Lines
server/server.go 46.66% 15 Missing and 1 partial ⚠️
cmd/pool.go 0.00% 5 Missing ⚠️
cmd/agency.go 33.33% 4 Missing ⚠️
cmd/key.go 0.00% 3 Missing ⚠️
cmd/export.go 0.00% 2 Missing ⚠️
cmd/import.go 0.00% 2 Missing ⚠️
protocol/notification/problem_report.go 0.00% 2 Missing ⚠️
cmd/completion.go 0.00% 1 Missing ⚠️
cmd/ledger.go 0.00% 1 Missing ⚠️
cmd/steward.go 66.66% 1 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #515      +/-   ##
==========================================
- Coverage   76.48%   76.47%   -0.01%     
==========================================
  Files         130      130              
  Lines        7573     7601      +28     
==========================================
+ Hits         5792     5813      +21     
- Misses       1585     1593       +8     
+ Partials      196      195       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lainio lainio merged commit 1bc3596 into dev Mar 7, 2024
8 of 9 checks passed
@lainio lainio deleted the dynamic-invitation branch March 7, 2024 18:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant