System{Info,Logs}: use sh instead of bash#167
Merged
Conversation
Bash is not available in Alpine images. In bb1ce0a, the Docker image was changed to Alpine from Debian, which caused 500 errors in the SystemInfoViewSet and SystemLogsViewSet. Now it calls "sh" instead of "/bin/bash", which should be more portable across different distributions. Since no bash-exclusive features were used, this was trivial. Fixes #62
Collaborator
|
@HenkKalkwater I suggest adding tests to monitor this functional |
Contributor
Author
|
@paktusov Given that this code interacts with the system, which may give different results depending on where you run it, when you run it et cetera, what should I test? Should I simply tests whether the methods give some non-error outputs or would you suggest something else? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bash is not available in Alpine images. In
bb1ce0a, the Docker image was changed to Alpine from Debian, which caused 500 errors in the SystemInfoViewSet and SystemLogsViewSet.
Now it calls "sh" instead of "/bin/bash", which should be more portable across different distributions. Since no bash-exclusive features were used, this was trivial.
Fixes #62