Skip to content

performance report: no error on portfolios without reports #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paktusov merged 1 commit into from
Feb 24, 2026
+0 −14
Merged

performance report: no error on portfolios without reports #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions poms/reports/performance_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1010,7 +1010,6 @@ def build_modified_dietz(self, date_from, date_to): # noqa: PLR0915

if date_to > date_from:
no_first_date = []
no_register_records = []
for register in portfolio_registers:
portfolio = register.portfolio
first_transaction_date = portfolio.first_transaction_date
Expand All @@ -1029,10 +1028,6 @@ def build_modified_dietz(self, date_from, date_to): # noqa: PLR0915
],
).order_by("transaction_date")

if not portfolio_records:
no_register_records.append(portfolio.user_code)
continue

portfolio_records = portfolio_records.filter(
transaction_date__gte=max(
date_from, first_transaction_date
Expand Down Expand Up @@ -1125,15 +1120,6 @@ def build_modified_dietz(self, date_from, date_to): # noqa: PLR0915
# ),
# )

if no_register_records:
raise FinmarsBaseException(
error_key="no_portfolio_register_records",
message=(
f"No portfolio register records found for the following portfolios "
f"for the specified period: {', '.join(no_register_records)}"
),
)

try:
cf_adjusted_total_nav = total_nav + grand_cash_flow
wcf_adjusted_total_nav = total_nav + grand_cash_flow_weighted
Expand Down