Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for node 20 #144

Closed
wants to merge 2 commits into from
Closed

Support for node 20 #144

wants to merge 2 commits into from

Conversation

stalet
Copy link
Contributor

@stalet stalet commented Feb 5, 2024

When uploading files with node 20 I get an error. By forcing node to use the latest version of @google-cloud/storage (7.7.0) the problems goes away.

---Uploading 4 files---
/home/travis/build/finn/organisation-frontend/node_modules/.pnpm/stream-shift@1.0.1/node_modules/stream-shift/index.js:16
    return state.buffer[0].length
                           ^
TypeError: Cannot read properties of null (reading 'length')
    at getStateLength (/home/travis/build/finn/organisation-frontend/node_modules/.pnpm/stream-shift@1.0.1/node_modules/stream-shift/index.js:16:28)
    at shift (/home/travis/build/finn/organisation-frontend/node_modules/.pnpm/stream-shift@1.0.1/node_modules/stream-shift/index.js:6:99)
    at Duplexify._forward (/home/travis/build/finn/organisation-frontend/node_modules/.pnpm/duplexify@4.1.2/node_modules/duplexify/index.js:170:35)
    at PassThrough.onreadable (/home/travis/build/finn/organisation-frontend/node_modules/.pnpm/duplexify@4.1.2/node_modules/duplexify/index.js:136:10)
    at PassThrough.emit (node:events:518:28)
    at emitReadable_ (node:internal/streams/readable:832:12)
    at process.processTicksAndRejections (node:internal/process/task_queues:81:21)
Node.js v20.11.0

Co-authored-by: William Killerud <william@killerud.com>
@wkillerud
Copy link
Contributor

I imagine the tests fail because the PR is from a fork, and doesn't get the configured secrets. I'll see about opening a local PR with these changes.

@wkillerud
Copy link
Contributor

Continued in #145

@wkillerud wkillerud closed this Feb 5, 2024
@stalet stalet deleted the node-20-support branch February 8, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants