Rewrite channel selector to use updated message types #1345
Conversation
…o fdc3-for-web-impl-addon
|
@robmoffat I've finished cleaning up the aesthetics, so this PR is ready for you to review and merge. |
There was a problem hiding this comment.
Thanks for having a go at this @julianna-ciq. Needs a few updates for new message type names. Could also ensure typing is applied to messages sent and that you only ever reference the top-level types for the messages, rather than using the payload types directly (as their naming may be unstable.
Thanks for identifying the styling race - what do you think about ways of avoiding it without using a setTimeout
| collapse(); | ||
| break; | ||
| } | ||
| case "iframeChannels": { |
There was a problem hiding this comment.
Needs updating to the fdc3UserInterface* messsages after we changed the name(s)
| case "iframeChannels": { | |
| case "fdc3UserInterfaceChannels": { |
There was a problem hiding this comment.
@kriswest those changes aren't merged into fdc3-for-web-impl so @julianna-ciq's code is correct as it stands.
| const {userChannels, selected} = data.payload as IframeChannelsPayload; | ||
| fillChannels(userChannels, selected, (channelStr) => { | ||
| myPort.postMessage({ | ||
| type: "iframeChannelSelected", |
There was a problem hiding this comment.
Needs update
| type: "iframeChannelSelected", | |
| type: "fdc3UserInterfaceSelected", |
| }; | ||
|
|
||
| parent.postMessage({ | ||
| type: "iframeHello", |
There was a problem hiding this comment.
| type: "iframeHello", | |
| type: "fdc3UserInterfaceHello", |
| const expand = () => { | ||
| document.body.setAttribute("data-expanded", "true"); | ||
| myPort.postMessage({ | ||
| type: "iframeRestyle", |
There was a problem hiding this comment.
| type: "iframeRestyle", | |
| type: "fdc3UserInterfaceRestyle", |
|
|
||
| const collapse = () => { | ||
| myPort.postMessage({ | ||
| type: "iframeRestyle", |
There was a problem hiding this comment.
| type: "iframeRestyle", | |
| type: "fdc3UserInterfaceRestyle", |
| break; | ||
| } | ||
| case "iframeResolve": { | ||
| myPort.postMessage({ |
There was a problem hiding this comment.
Init and type the message as an object, then post
| payload: s | ||
| }); | ||
|
|
||
| myPort.postMessage({ |
There was a problem hiding this comment.
Init and type message then post
| }); | ||
|
|
||
| myPort.postMessage({ | ||
| type: "iframeRestyle", |
There was a problem hiding this comment.
| type: "iframeRestyle", | |
| type: "fdc3UserInterfaceRestyle", |
|
|
||
| }; | ||
|
|
||
| parent.postMessage({ |
There was a problem hiding this comment.
Init and type message then post
| }; | ||
|
|
||
| parent.postMessage({ | ||
| type: "iframeHello", |
There was a problem hiding this comment.
| type: "iframeHello", | |
| type: "fdc3UserInterfaceHello", |
|
Nah, that just means there's stuff the other end to change too :-p I wasn't saying she got it wrong, rather just highlighting the places that it will need to change as we changed the message names. |
Oh right ok. Well look, I'm on holiday for the next couple of weeks, so you've got a window to get everything straightened out before I get round to merging / search and replace. |
No description provided.