Skip to content

MEDIA-4876: add support for bigger data channel message size#409

Open
reddvl1980 wants to merge 24 commits intomasterfrom
MEDIA-4876-pr
Open

MEDIA-4876: add support for bigger data channel message size#409
reddvl1980 wants to merge 24 commits intomasterfrom
MEDIA-4876-pr

Conversation

@reddvl1980
Copy link
Copy Markdown
Contributor

@reddvl1980 reddvl1980 commented Apr 7, 2026 •
edited
Loading

  • Introdicing "PoolBuffer" - multi-chunk memory buffer to store sctp messages.
  • Code is optimized so that when the message fit into single chunk copying on readong is not performed.
  • For temporary storage memory::Array<2048> is bing used so that if the message size fits 2048 bytes it's allocated on stack.
  • Conference actions now return data['max-message-size'] - needed by SFU to return SDP to the c9 Trader Client. Max-message-size is omitted in barbell replys.
  • Max message size is configured via config.sctp.maxMessageSize with the default value of 2048
  • Unit tests added for PoolBuffer, sending pipeline, full forwarding pipline (requried adding of Engine mock).

RicardoMDomingues
RicardoMDomingues reviewed Apr 7, 2026
View reviewed changes
reddvl1980 added 19 commits April 7, 2026 14:04
@reddvl1980
MEDIA-4876: delete unnecessary IEngine
a92482c
@reddvl1980
MEDIA-4876: address PR issues (rename)
9c7e129
@reddvl1980
MEDIA-4876: address dynamic memory issues
7d36059
@reddvl1980
MEDIA-4876: pass PoolBuffer instead of copying
fce5c0d
@reddvl1980
MEDIA-4876: fix custom deleter for PoolBuffer
1eb3951
@reddvl1980
MEDIA-4876: get rid of AsIs and NullTerminated helpers
0026d95
@reddvl1980
MEDIA-4876: make sendSctp accept PoolBuffer rather then data*,len
4b3e597
@reddvl1980
MEDIA-4876: wip
92abf83
@reddvl1980
MEDIA-4876: address cpp-check issue
5fc2160
@reddvl1980
MEDIA-4876: renamed WebRtcDataStream::onSctpMessage -> onSctpMessageB…
e4eccd0 
…uffer to

   differentiate from DataReceiver::onSctpMessage
@reddvl1980
MEDIA-4876: get rid of use getReadonlyBuffer() in EngineMixer::sendEn…
daa24f2 
…dpointMessage
@reddvl1980
MEDIA-4876: get rid of use getReadonlyBuffer() in EngineMixer::proces…
88835b8 
…sBarbellSctp
@reddvl1980
MEDIA-4876: fix typo in unit test detected by DCheck build
6939267
@reddvl1980
MEDIA-4876: add graceful termination of MixerManger to DataCHannelMes…
83a64ab 
…sageSizeTest (DCheck)
@reddvl1980
MEDIA-4876: PoolBuffer mem optimizaton 1/2
5e980af 
Allow provide preallocated "master chunk" to PoolBuffer c'tor to
optmize makeUniquePoolBuffer(): now PoolBuffer and "master chunk"
use the same pre-allocated pool packet.
@reddvl1980
MEDIA-4876: PoolBuffer mem optimization 2/2
5377830 
Make use of master chunk capacity to store some actual data.
@reddvl1980
MEDIA-4876: remove view() class from PoolBuffer
d1438b5
@reddvl1980
MEDIA-4876: renamed PoolBuffer read/write to copyFrom/copyTo
a95ec93
@reddvl1980
MEDIA-4876: get rid of getContinuesBuffer in favor of on-stack variab…
e3c6925 
…le-size C buffers (max 8192)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RicardoMDomingues RicardoMDomingues RicardoMDomingues left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reddvl1980 @RicardoMDomingues