Skip to content

Conversation

@regnosys-prod-user
Copy link
Collaborator

No description provided.

@regnosys-prod-user regnosys-prod-user requested a review from a team as a code owner October 21, 2025 09:49
@regnosys-prod-user
Copy link
Collaborator Author

CDM Event Model - Termination for Schedules

Background

When a termination applies to a quantity schedule, all the dated values from the effective period onwards should be set to zero.

What is being released?

The UpdateQuantityAmountForEachMatchingQuantity function has been enhanced to apply the quantity change to all dated values from the current period onward. A new function UpdateDatedValues has been created to perform the update of the DatedValue.

The period from which the change should take effect is determined using the primitiveInstruction → quantityChange → change → effectiveDate.

Mappings

The mapping from the FpML termination effective date has been added to the function MapPriceQuantity pointing to the primitiveInstruction → quantityChange → change → effectiveDate.

Review Directions

Changes can be reviewed in PR: #4123

Note

This comment was generated via Rosetta.

@regnosys-prod-user regnosys-prod-user added the Rosetta Pull requests which can be viewed in Rosetta label Oct 21, 2025
@netlify
Copy link

netlify bot commented Oct 21, 2025

Deploy Preview for finos-cdm ready!

Name Link
🔨 Latest commit d771669
🔍 Latest deploy log https://app.netlify.com/projects/finos-cdm/deploys/6911c59b0526620008e7a252
😎 Deploy Preview https://deploy-preview-4123--finos-cdm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@gtarres
Copy link
Contributor

gtarres commented Oct 21, 2025

This PR replaces PR #4001 (mappings added and conflicts solved).

@gtarres
Copy link
Contributor

gtarres commented Oct 30, 2025

@CDM-ReleaseManagement-OT the code was updated to the last version, but the build appears to be still failing. Could you please assist us in resolving this? Thanks in advance,

@JayasriR
Copy link
Contributor

Superseded by #4144

@regnosys-prod-user regnosys-prod-user removed the Rosetta Pull requests which can be viewed in Rosetta label Nov 5, 2025
@regnosys-prod-user
Copy link
Collaborator Author

What is being released?

Minor style improvements.

Note

This comment was generated via Rosetta.

@regnosys-prod-user regnosys-prod-user added the Rosetta Pull requests which can be viewed in Rosetta label Nov 5, 2025
@gtarres
Copy link
Contributor

gtarres commented Nov 5, 2025

Event Model - Termination for Schedules

Background

Previously, when a termination applied to a quantity schedule, the model did not correctly update all dated values following the termination’s effective period. As a result, quantities after the termination date could still retain non-zero values.

To address this, the logic has been improved so that any dated values from the effective period onward are correctly set to zero when a termination occurs.

What is being released?

The UpdateQuantityAmountForEachMatchingQuantity function has been enhanced to apply the quantity change to all dated values from the current period onward. A new function UpdateDatedValues has been created to perform the update of the DatedValue.

The period from which the change should take effect is determined using the primitiveInstruction → quantityChange → change → effectiveDate.

Mappings

The mapping from the FpML termination effective date has been added to the function MapPriceQuantity pointing to the primitiveInstruction → quantityChange → change → effectiveDate.

Review Directions

Changes can be reviewed in PR: #4123

@regnosys-prod-user regnosys-prod-user removed the Rosetta Pull requests which can be viewed in Rosetta label Nov 10, 2025
@regnosys-prod-user
Copy link
Collaborator Author

What is being released?

fixed bug for multiple quantities.

Note

This comment was generated via Rosetta.

@regnosys-prod-user regnosys-prod-user added the Rosetta Pull requests which can be viewed in Rosetta label Nov 10, 2025
@hugohills-regnosys hugohills-regnosys deleted the gtarr_6226136367f2fb0069976cb-schedules-decrease-7dev-complete branch November 10, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Rosetta Pull requests which can be viewed in Rosetta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Support for Schedule Quantities in Create_QuantityChange Function

5 participants