Open
Conversation
…eration steps. Merge in FLUXNOVA/fluxnova-bpm-platform from feature/gha-build-javadoc-restapi to db-feature/gha-build-javadoc-restapi * commit '7d8003b819d8068fa9040a7aa07127a2c80dab3b': Extended workflow with Javadocs and openAPI generation steps.
pieter-schutte
previously approved these changes
Jan 22, 2026
deutschebank-sync
force-pushed
the
db-contrib/gha-build-javadoc-restapi
branch
from
177cf7e to
96607ff
Compare
Contributor
|
https://github.com/finos/fluxnova-bpm-platform/actions/runs/21280546449/job/61249254191?pr=66 |
deutschebank-sync
force-pushed
the
db-contrib/gha-build-javadoc-restapi
branch
from
6eb8814 to
96607ff
Compare
|
|
||
| - name: Generate Javadoc | ||
| run: | | ||
| mvn -B -e package javadoc:javadoc javadoc:aggregate \ |
Contributor
There was a problem hiding this comment.
@gaborherr-db Thanks for adding this java doc generate action in release workflow. This is much needed change that we have been talking about. Were you guys able to do end to end testing?
| with: | ||
| github_token: ${{ secrets.GITHUB_TOKEN }} | ||
| publish_dir: ./engine-rest/engine-rest-openapi/target/generated-source/openapi-json | ||
| destination_dir: openapi/${{ needs.publish-central.outputs.minor_version }} |
Contributor
There was a problem hiding this comment.
Do we know where we’ll host it after the pages are generated and moved to openapi/* folder??
prajwolbhandari1
approved these changes
Feb 2, 2026
Contributor
prajwolbhandari1
left a comment
prajwolbhandari1
left a comment
There was a problem hiding this comment.
Looks good to me other than few questions
pieter-schutte
approved these changes
Feb 6, 2026
Contributor
|
Approved on the assumption that your upstream PRs will resolve the build issues |
Contributor
|
@gaborherr-db please resolve conflicts (and it will also trigger a build) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds building of javadocs and openapi generation with GHA. I am not sure if it works, but it is hard to test from here. Any fixes will be appreciated.