Add support for post deployment actions #3176
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yasirmod17
commented
Oct 14, 2024
|
|
||
| public class PostDeploymentResult | ||
| { | ||
| public String actionType; |
There was a problem hiding this comment.
Should this also carry a success/failure flag? so we know how to interpret the detail
| @@ -122,4 +135,14 @@ public static String fullName(org.finos.legend.engine.protocol.pure.v1.model.pac | |||
| return e._package + "::" + e.name; | |||
| } | |||
|
|
|||
| public static List<ActionContent> renderActions(RichIterable<? extends Root_meta_external_function_activator_postDeploymentAction_PostDeploymentAction> actions) | |||
There was a problem hiding this comment.
This should leverage PostDeploymentLoader, not duplicate the code
| import java.util.ServiceLoader; | ||
| import java.util.concurrent.atomic.AtomicReference; | ||
|
|
||
| public class PostDeploymentLoader |
There was a problem hiding this comment.
to keep the naming consistent: This should be PostDeploymentActionLoader
|
|
||
| package org.finos.legend.engine.protocol.functionActivator.deployment; | ||
|
|
||
| public class PostDeploymentResult |
There was a problem hiding this comment.
to keep the naming consistent: This should be PostDeploymentActionResult
| <groupId>org.finos.legend.engine</groupId> | ||
| <artifactId>legend-engine-identity-core</artifactId> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
Why do we have the -pure dependency in this pom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do / why is it needed ?
Which issue(s) this PR fixes:
Fixes #
Other notes for reviewers:
Does this PR introduce a user-facing change?