Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compiled state integrity tests for several modules #3190

Merged
merged 13 commits into from
Oct 22, 2024

Conversation

kevin-m-knight-gs
Copy link
Contributor

@kevin-m-knight-gs kevin-m-knight-gs commented Oct 21, 2024

What type of PR is this?

Improvement

What does this PR do / why is it needed ?

Add compiled state integrity tests for several modules. Ideally, every module which defines a Pure repo should have such a test.

In passing, fix typos in the names of some existing compiled state integrity tests, and clean up the test for core.

Does this PR introduce a user-facing change?

No

@kevin-m-knight-gs kevin-m-knight-gs requested a review from a team as a code owner October 21, 2024 22:00
Copy link

Test Results

  1 051 files  +  11    1 051 suites  +11   1h 39m 14s ⏱️ + 12m 52s
12 713 tests +341  12 604 ✔️ +322  109 💤 +19  0 ±0 
18 508 runs  +341  18 399 ✔️ +322  109 💤 +19  0 ±0 

Results for commit a07b518. ± Comparison against base commit 2c326f2.

@kevin-m-knight-gs kevin-m-knight-gs changed the title Add several compiled state integrity tests Add compiled state integrity tests for several modules Oct 22, 2024
@kevin-m-knight-gs kevin-m-knight-gs merged commit a4b22af into finos:master Oct 22, 2024
3 of 4 checks passed
@kevin-m-knight-gs kevin-m-knight-gs deleted the integrity_test branch October 22, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants