Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VUU-333: Add Spring Boot integration tests for valid JSON in 'definition' field of layout requests #1028

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cfisher-scottlogic
Copy link
Contributor

@cfisher-scottlogic cfisher-scottlogic commented Nov 28, 2023

Description

SL Ticket
SL PR

This PR refactored the type of LayoutRequestDTO.definition to ObjectNode to enforce a valid JSON constraint. Tests to ensure this enforcement is successful are missing. This PR adds those tests.

Change List

  • LayoutIntegrationTest & ApplicationIntegrationTest: Add tests for the creation and updating of layouts when the definition is not valid JSON

Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for papaya-valkyrie-395400 ready!

Name Link
🔨 Latest commit 9ed74e2
🔍 Latest deploy log https://app.netlify.com/sites/papaya-valkyrie-395400/deploys/6566188fd7fd910008713f98
😎 Deploy Preview https://deploy-preview-1028--papaya-valkyrie-395400.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant