-
Notifications
You must be signed in to change notification settings - Fork 126
Analytics windows dll update #1791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…for latest changes. Add latest google_analytics.dll and corresponding public header files. Also added the implementations for SetLogCallback and NotifyAppLifecycleChange.
Add missing header file.
Added integration test and removed the ability to set logging callback for now. Will add in the future.
Summary of ChangesHello @john-mikhail, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on updating the Windows Analytics DLL to its latest version, which includes a new naming convention for the DLL. A significant new feature is the introduction of an Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the analytics Windows DLL to its latest version, which introduces several API changes. A new function, NotifyAppLifecycleChange
, has been added to handle app lifecycle events, and this is now correctly called during termination to ensure analytics data is flushed. The codebase has been updated to reflect other API changes, such as modified function signatures and new initialization options. The integration tests have also been updated to cover the new functionality. My review includes a couple of minor suggestions to improve documentation and code readability.
Fix typo Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
❌ Integration test FAILEDRequested by @john-mikhail on commit de68294
Add flaky tests to go/fpl-cpp-flake-tracker |
…ebase/firebase-cpp-sdk into analytics-windows-dll-update
Description
Updated the analytics dll to the latest version and added an implementation of NotifyAppLifecycleChange,
Testing
Built and ran the analytics/integration_test.exe with all tests passing:
Type of Change
Place an
x
the applicable box: