[Vertex AI] Use struct instead of enum for HarmCategory
#13728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewheard
force-pushed
the
ah/vertex-extensible-enum
branch
from
6049f5c to
5dc2415
Compare
google-oss-bot
added
api: abtesting
api: analytics
api: appcheck
api: appdistribution
api: auth
api: core
api: crashlytics
api: database
api: dynamiclinks
api: firestore
api: functions
api: inappmessaging
andrewheard
removed
api: messaging
api: storage
api: firestore
api: analytics
api: dynamiclinks
api: performance
api: remoteconfig
api: crashlytics
api: functions
api: inappmessaging
ncooke3
reviewed
Oct 8, 2024
FirebaseVertexAI/Sample/ChatSample/Views/ErrorDetailsView.swift
Outdated
Show resolved
Hide resolved
ncooke3
reviewed
Oct 8, 2024
ncooke3
approved these changes
Oct 8, 2024
paulb777
approved these changes
Oct 8, 2024
MojtabaHs
pushed a commit
to MojtabaHs/firebase-ios-sdk
that referenced
this pull request
Oct 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the
HarmCategoryenum with a struct to prevent breaking changes when new values are added (since switch statements must be exhaustively checked in Swift). Added support forHARM_CATEGORY_CIVIC_INTEGRITY.#no-changelog