Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Config] Add generated tests for UserDefaultsManagerTests.swift #14337

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jan 10, 2025

This did require some tweaking and I did add two tests. Commented out tests that were generated but used private APIs. I'm in favor of deleting the tests instead of making the tested API internal, but wanted to surface this in case there are other views.

#no-changelog

@ncooke3 ncooke3 changed the title [Config] Add generated tests for UserDefaultsManagerTests.swif [Config] Add generated tests for UserDefaultsManagerTests.swift Jan 10, 2025
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to delete commented tests.

@ncooke3 ncooke3 merged commit fdf6d5e into rc-swift Jan 13, 2025
26 of 28 checks passed
@ncooke3 ncooke3 deleted the nc/rc-swift-tests-3 branch January 13, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants