-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add AsyncStream support for Remote Config #15352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @peterfriese !
Leaving approval to @ncooke3 or the RC team
@@ -1,3 +1,9 @@ | |||
# unreleased | |||
- [added] Introduced a new `updates` property to `RemoteConfig` that | |||
providesan `AsyncThrowingStream` for consuming real-time config updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "provides an"
```swift | ||
extension StorageTask { | ||
/// An asynchronous stream of progress updates for an ongoing task. | ||
var progress: AsyncThrowingStream<StorageTaskProgress, Error> { get } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Storage already has a progress
var
@@ -1,3 +1,9 @@ | |||
# unreleased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: format so it's picked up by release scripting
# unreleased | |
# Unreleased |
No description provided.