Skip to content

Conversation

peterfriese
Copy link
Contributor

No description provided.

@peterfriese peterfriese self-assigned this Sep 22, 2025
@peterfriese peterfriese linked an issue Sep 22, 2025 that may be closed by this pull request
@peterfriese peterfriese marked this pull request as ready for review September 22, 2025 21:52
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @peterfriese !

Leaving approval to @ncooke3 or the RC team

@@ -1,3 +1,9 @@
# unreleased
- [added] Introduced a new `updates` property to `RemoteConfig` that
providesan `AsyncThrowingStream` for consuming real-time config updates.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "provides an"

```swift
extension StorageTask {
/// An asynchronous stream of progress updates for an ongoing task.
var progress: AsyncThrowingStream<StorageTaskProgress, Error> { get }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storage already has a progress var

@@ -1,3 +1,9 @@
# unreleased
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: format so it's picked up by release scripting

Suggested change
# unreleased
# Unreleased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement AsyncStream support for Remote Config
3 participants