Update FirebaseErrorHandler angular class to take app

[tonybaroneee]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 0b23869

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[gemini-code-assist]

Summary of Changes

Hello @tonybaroneee, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the FirebaseErrorHandler class within the Angular Telemetry package by modifying its constructor to accept a FirebaseApp instance directly. This change ensures that the error handler is explicitly linked to a specific Firebase application, improving the robustness and predictability of telemetry data collection. The update includes corresponding changes to documentation, examples, and tests to align with this new dependency.

Highlights

• Constructor Signature Change: The FirebaseErrorHandler class constructor now explicitly requires a FirebaseApp instance as its first argument, enhancing clarity and control over the associated Firebase application.
• Internal Logic Update: The FirebaseErrorHandler now utilizes the FirebaseApp instance provided during its construction for telemetry operations, rather than implicitly retrieving it via getApp().
• Documentation and Examples: All relevant documentation, API review files, and code examples have been updated to reflect the new constructor signature and demonstrate the correct way to provide the FirebaseApp instance, typically using a useFactory provider in Angular modules.
• Test Updates: Unit tests for FirebaseErrorHandler have been adjusted to pass the required FirebaseApp instance during instantiation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the FirebaseErrorHandler Angular class to explicitly take a FirebaseApp instance in its constructor. This is a positive change that improves dependency injection and testability by making the FirebaseApp dependency explicit rather than relying on a global getApp() call within the class. The changes are well-implemented, and all related documentation and test files have been updated accordingly. No issues of medium, high, or critical severity were found.

[google-oss-bot]

Size Report ¹

Affected Products

No changes between base commit (45e28bd) and merge commit (0d5ba1c).

Test Logs

• Base (45e28bd): https://github.com/firebase/firebase-js-sdk/actions/runs/19898185424
• Merge (0d5ba1c): https://github.com/firebase/firebase-js-sdk/actions/runs/19900629475

1. https://storage.googleapis.com/firebase-sdk-metric-reports/jlwP6b3uBQ.html

[google-oss-bot]

Size Analysis Report ¹

Affected Products

No changes between base commit (45e28bd) and merge commit (0d5ba1c).

Test Logs

• Base (45e28bd): https://github.com/firebase/firebase-js-sdk/actions/runs/19898185424
• Merge (0d5ba1c): https://github.com/firebase/firebase-js-sdk/actions/runs/19900629475

1. https://storage.googleapis.com/firebase-sdk-metric-reports/wpWUVjpEWr.html