Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(app_check): add additional steps to ensure App Check works on specific devices #17110

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SelaseKay
Copy link
Contributor

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@SelaseKay SelaseKay changed the title doc(app_check): add additional steps to ensure App Check works on specific devices docs(app_check): add additional steps to ensure App Check works on specific devices Feb 18, 2025
Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some suggestions 👍

@@ -141,3 +141,8 @@ environment, you can create a debug build of your app that uses the
App Check debug provider instead of a real attestation provider.

See [Use App Check with the debug provider in Flutter apps](/docs/app-check/flutter/debug-provider).

### Additional Steps to Enable App Check on Specific Devices (e.g. Xiaomi)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Additional Steps to Enable App Check on Specific Devices (e.g. Xiaomi)

@@ -141,3 +141,8 @@ environment, you can create a debug build of your app that uses the
App Check debug provider instead of a real attestation provider.

See [Use App Check with the debug provider in Flutter apps](/docs/app-check/flutter/debug-provider).

### Additional Steps to Enable App Check on Specific Devices (e.g. Xiaomi)
For certain devices like Xiaomi, you need to enable "Meets basic device integrity" in the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For certain devices like Xiaomi, you need to enable "Meets basic device integrity" in the
Note: For certain Android devices, you need to enable "Meets basic device integrity" in the


### Additional Steps to Enable App Check on Specific Devices (e.g. Xiaomi)
For certain devices like Xiaomi, you need to enable "Meets basic device integrity" in the
Play Integrity API settings, as mentioned in [this issue comment](https://github.com/firebase/flutterfire/issues/17106#issuecomment-2663422877),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Play Integrity API settings, as mentioned in [this issue comment](https://github.com/firebase/flutterfire/issues/17106#issuecomment-2663422877),
Play console

Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That ought to do it 😄

Comment on lines 145 to 146
Note: For certain Android devices, you need to enable "Meets basic device integrity" in the
Play console.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Note: For certain Android devices, you need to enable "Meets basic device integrity" in the
Play console.
Note: For certain Android devices, you may need to enable "Meets basic device integrity" in the
Google Play console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants