refactor(plugins/checks): migrate to v2 API #3541
Open
+28
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabljac
reviewed
Sep 16, 2025
cabljac
reviewed
Sep 22, 2025
cabljac
reviewed
Sep 29, 2025
js/plugins/checks/src/index.ts
Outdated
| return checksEvaluators(googleAuth, metrics, await projectId); | ||
| }, | ||
| list: async () => { | ||
| return [checksEvaluators(googleAuth, metrics, await projectId).__action]; |
There was a problem hiding this comment.
hmm are we definitely meant to use __action
There was a problem hiding this comment.
Honestly, I'm not too sure. It did seem to work, but I'll look into this.
dackers86
reviewed
Sep 30, 2025
| const googleAuth = inititializeAuth(options?.googleAuthOptions); | ||
|
|
||
| const projectId = options?.projectId || (await googleAuth.getProjectId()); | ||
| const projectId = options?.projectId || googleAuth.getProjectId(); |
There was a problem hiding this comment.
Does this no longer need to be awaited?
There was a problem hiding this comment.
It still is awaited on line 69, 72, and 75
Edit: now 68 and 71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3444
migration guide: https://docs.google.com/document/d/1s1YKwhqdrGN44IG7lSAwltxM3Bqh9p6jTcri8SNaBWk/edit?usp=sharing
Checklist (if applicable):