fix(js/plugins/google-genai): use .start on background model action in test #3645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migration has failing tests. I believe for a background model action you have to call them as methods instead of destructuring.
The captureModelRunner function is returning an instance of
BackgroundActionImplat runtime, and if we destructure we lose it'sthisbinding as we're creating a new objectstarthttps://github.com/firebase/genkit/blob/main/js/core/src/background-action.ts#L107
results in
undefinedtype errors in tests:TODO: on reflection I'm going to give the test changes in the base PR further review