fix(go): remove unnecessary nil check for lookup model #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ActionDef)(nil)` when no model is found, which is different from `nil`
yukinagae
changed the title
yukinagae
changed the title
yukinagae
added a commit
to yukinagae/genkit-golang-openai-sample
that referenced
this pull request
Aug 27, 2024
|
I'll close this PR because removing the nil check in this case seems like bad practice. Instead of removing the nil check, I'll modify |
|
I've submitted an issue instead of this PR: #847 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary nil check as lookup model (
ai.LookupModel(provider, name)) returns(*ai.modelActionDef)(nil)when no model is found, which is different fromnilin this case.The below playground shows how it looks like:
https://go.dev/play/p/u-OvxaXc3aZ
Also, this article explains this problem.
https://vitaneri.com/posts/check-for-nil-interface-in-go
Checklist (if applicable):