Refactor/esm #1331
Refactor/esm #1331
Conversation
ANGkeith
force-pushed
the
refactor/esm
branch
7 times, most recently
from
0a1d32c
to
863e0d4
Compare
ANGkeith
force-pushed
the
refactor/esm
branch
3 times, most recently
from
4fb06eb
to
1834e2a
Compare
ANGkeith
force-pushed
the
refactor/esm
branch
3 times, most recently
from
83f90be
to
7082996
Compare
|
@ANGkeith Can you pull master. I'll review this in this week. I really want to upgrade to ESM 😄 |
|
@ANGkeith Can you pull master again, and I'll put some time into testing this thoroughly |
- when using tsx unable to get source-mapping to work
- was getting the exact same error as per jestjs/jest#15000
|
|
@ANGkeith It has been done |
| "useESM": true | ||
| } | ||
| ], | ||
| "^.+\\.jsx?$": "babel-jest" |
There was a problem hiding this comment.
wondering, why we add back this babel-jest ?
i thought its made redundant after 9b1efdb
There was a problem hiding this comment.
I just wanted the PR in master didn't want to spent too much time on it.
We might be able to get rid of it.
There was a problem hiding this comment.
oo ok, glad too this PR is finally in master
the rest of the changes makes sense to me, thanks for the review
This is quite a big mr, but i tried to break down the changes into smaller commits
for actual file changes, can see
https://github.com/firecow/gitlab-ci-local/pull/1331/files/d06df308016637357d191e8be74a11194fa2ad2b..8760e7c3304f39fd4604ac5f64ab65edb06f6e9b
instead,
since the "ts2esm vooodo" commit is mostly autogenerated