Add batch APIs to improve performance

firegiant · Jan 16, 2019 · d8069a0 · d8069a0
1 parent 544c788
commit d8069a0
Show file tree

Hide file tree

Showing 25 changed files with 992 additions and 576 deletions.
diff --git a/src/SleetLib/Commands/DeleteCommand.cs b/src/SleetLib/Commands/DeleteCommand.cs
@@ -39,8 +39,9 @@ public static async Task<bool> RunAsync(LocalSettings settings, ISleetFileSystem
                 };
 
                 var packageIndex = new PackageIndex(context);
+                var existingPackageSets = await packageIndex.GetPackageSetsAsync();
 
-                var packages = new List<PackageIdentity>();
+                var packages = new HashSet<PackageIdentity>();
 
                 if (!string.IsNullOrEmpty(version))
                 {
@@ -52,18 +53,22 @@ public static async Task<bool> RunAsync(LocalSettings settings, ISleetFileSystem
                 else
                 {
                     // Delete all versions of the package
-                    packages.AddRange(await packageIndex.GetPackagesByIdAsync(packageId));
+                    packages.UnionWith(await existingPackageSets.Packages.GetPackagesByIdAsync(packageId));
+                    packages.UnionWith(await existingPackageSets.Symbols.GetPackagesByIdAsync(packageId));
                 }
 
                 if (string.IsNullOrEmpty(reason))
                 {
                     reason = string.Empty;
                 }
 
+                var toRemove = new HashSet<PackageIdentity>();
+                var toRemoveSymbols = new HashSet<PackageIdentity>();
+
                 foreach (var package in packages)
                 {
-                    var exists = await packageIndex.Exists(package);
-                    var symbolsExists = await packageIndex.SymbolsExists(package);
+                    var exists = existingPackageSets.Packages.Exists(package);
+                    var symbolsExists = existingPackageSets.Symbols.Exists(package);
 
                     if (!exists && !symbolsExists)
                     {
@@ -80,6 +85,16 @@ public static async Task<bool> RunAsync(LocalSettings settings, ISleetFileSystem
                         }
                     }
 
+                    if (exists)
+                    {
+                        toRemove.Add(package);
+                    }
+
+                    if (symbolsExists)
+                    {
+                        toRemoveSymbols.Add(package);
+                    }
+
                     var message = $"Removing {package.ToString()}";
 
                     if (exists && symbolsExists)
@@ -92,10 +107,13 @@ public static async Task<bool> RunAsync(LocalSettings settings, ISleetFileSystem
                     }
 
                     await log.LogAsync(LogLevel.Information, message);
-
-                    await SleetUtility.RemovePackage(context, package);
                 }
 
+                // Update feed
+                await log.LogAsync(LogLevel.Information, "Removing packages from feed locally");
+                await SleetUtility.RemoveNonSymbolsPackages(context, toRemove);
+                await SleetUtility.RemoveSymbolsPackages(context, toRemoveSymbols);
+
                 // Save all
                 log.LogMinimal($"Committing changes to {source.BaseURI.AbsoluteUri}");