Skip to content

Conversation

@Kcheung42
Copy link
Collaborator

Purpose

Related Issues

Closes BHP1-1368

Submission Checklist

  • Included Jira issue in the PR title (e.g. BHP1-### <title>)
  • Code passes linter rules (clj-kondo --lint components/**/src bases/**/src projects/**/src)
  • Feature(s) work when compiled (clojure -M:compile-cljs)

Testing

There's quite a bit to views to test but there are two patterns to check

  1. A simple table entity form (i.e. Modules, variables, tools, etc..) where it does not trigger a secondary table
  2. A table entity form that triggers a second set of tables (i.e. Variable Domains, Lists, Tags, Units)

Testing Simple (Variables)

  1. Ensure all entities show as expected
  2. Ensure you can edit any selection
  3. Ensure you can add an entry

Testing Slightly less Simple (Variable Domains)

  1. Ensure when selecting a domain-set to edit a second table appears for the domains
  2. Ensure you can edit domain-sets and domains
  3. Ensure when changing a domain set to edit, the corresponding table also changes.

Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants