update to main for core #75
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchris
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
note for later -- there's no shared test for these gateways in this repo (unless this PR adds one) and most of this behavior is shared
| // } | ||
| // if (!dataStore.ebOpts.store.stores.base) { | ||
| // throw new Error("Loader stores.base is not defined"); | ||
| // } |
| const { store } = getStore(url, this.sthis, (...args) => args.join("/")); | ||
|
|
||
| const rParams = url.getParamsResult("uploadUrl", "key", "name"); | ||
| if (rParams.isErr()) { | ||
| return this.logger.Error().Url(url).Err(rParams).Msg("Put Error").ResultError(); | ||
| } | ||
| const { uploadUrl, key, name } = rParams.Ok(); | ||
| const body = await rt.gw.fpSerialize(this.sthis, fpEnv, url); |
| @@ -147,34 +140,22 @@ export class AWSGateway implements bs.Gateway { | |||
| } | |||
| } | |||
|
|
|||
| private async getData(url: URI): Promise<bs.GetResult> { | |||
| async getRaw(url: URI): Promise<Result<Uint8Array>> { | |||
There was a problem hiding this comment.
I didn't listen to many of these yet but the function has theme songs
| @@ -52,7 +52,7 @@ export const connect: ConnectFunction = ( | |||
| return connectionCache.get(urlObj.toString()).once(() => { | |||
| makeKeyBagUrlExtractable(sthis); | |||
| const connection = connectionFactory(sthis, urlObj); | |||
| connection.connect_X(blockstore); | |||
| connection.connect(crdt.blockstore); | |||
| const connection = rawConnect(db, doc.remoteName, URI.from(doc.endpoint).toString()); | ||
| const connectURI = URI.from(dashboardURI).build().pathname("/fp/databases/connect"); | ||
| connectURI.defParam("localName", dbName); | ||
| connectURI.defParam("remoteName", doc.remoteName); | ||
| if (doc.endpoint) { | ||
| connectURI.defParam("endpoint", doc.endpoint); | ||
| if (endpoint) { |
| @@ -85,35 +86,32 @@ export class NetlifyGateway implements bs.Gateway { | |||
| return Result.Err(new Error("Remote base URL not found in the URI")); | |||
| } | |||
| const fetchUrl = BuildURI.from(remoteBaseUrl); | |||
| switch (store) { | |||
| let body: Uint8Array; | |||
| switch (fpenv.type) { | |||
There was a problem hiding this comment.
that is easier to work with
| base: process.env.FP_STORAGE_URL, | ||
| }, | ||
| storeUrls: { | ||
| base: process.env.FP_STORAGE_URL, |
|
this should merge first, then merge #78 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.