Fix bug creating large spark spend tx (#1399)

firoorg · Jan 24, 2024 · 6d2b76c · 6d2b76c
1 parent 2347fb1
commit 6d2b76c
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/spark/sparkwallet.cpp b/src/spark/sparkwallet.cpp
@@ -1525,9 +1525,6 @@ CWalletTx CSparkWallet::CreateSparkSpendTransaction(
                 i++;
             }
 
-            // check fee
-            wtxNew.SetTx(MakeTransactionRef(std::move(tx)));
-
             if (GetTransactionWeight(tx) >= MAX_NEW_TX_WEIGHT) {
                 throw std::runtime_error(_("Transaction too large"));
             }
@@ -1546,6 +1543,8 @@ CWalletTx CSparkWallet::CreateSparkSpendTransaction(
                 throw std::invalid_argument(_("Not enough fee estimated"));
             }
 
+            wtxNew.SetTx(MakeTransactionRef(std::move(tx)));
+
             result.push_back(wtxNew);
         }
     }