Spark runaway exceptions #1344
Merged
Spark runaway exceptions #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levonpetrosyan93
approved these changes
Nov 18, 2023
reubenyap
added a commit
that referenced
this pull request
Nov 21, 2023
This reverts commit 62fc651.
reubenyap
added a commit
that referenced
this pull request
Nov 21, 2023
firstcryptoman
pushed a commit
that referenced
this pull request
Jan 15, 2024
* Avoid catch(...) when possible * Add wrappers around major sigma/lelantus/spark calls to catch exceptions * Catch exception thrown from CheckLelantusJMintTransaction * Bug fix * Fixed tests * Disable failing elysium test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR intention
In some cases low-level exceptions were able to leave lelantus/sigma in incorrect state. This PR prevents this behavior.
Code changes brief
Try/catch blocks are used