Grootle verification hardening #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
force-pushed
the
reject-spark-zero-keys
branch
from
b9eaf43
to
8e4e4c9
Compare
AaronFeickert
force-pushed
the
reject-spark-zero-keys
branch
from
8e4e4c9
to
24ea781
Compare
psolstice
approved these changes
Jan 14, 2024
levonpetrosyan93
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR intention
Hardens Grootle proof verification in Spark transactions.
Code changes brief
Offset commitments and challenge powers in Grootle proofs ought not to be zero. This PR ensures these things don't happen.