Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typos #1439

Merged
merged 1 commit into from
Jun 10, 2024
Merged

chore: fix typos #1439

merged 1 commit into from
Jun 10, 2024

Conversation

xiaoxianBoy
Copy link
Contributor

fix some typos

Signed-off-by: snoppy <michaleli@foxmail.com>
Copy link

coderabbitai bot commented May 23, 2024

Walkthrough

The changes made across various files are primarily focused on correcting typos in comments to improve clarity and accuracy. No functional code modifications were made, ensuring that the logic and behavior of the code remain unchanged. This update enhances the readability and professionalism of the codebase without altering its functionality.

Changes

File Path Change Summary
src/crypto/MerkleTreeProof/argon2.h Corrected a typo in a comment from "deafults" to "defaults"
src/ctpl.h Updated a comment in the stop function to correct a spelling error and clarify behavior
src/fixed.h Corrected a typo in a comment from "neccessarily" to "necessarily"
src/fuzz/FuzzedDataProvider.h Corrected a typo in a comment from "capaticity" to "capacity"
src/fuzz/README.md Corrected typos in instructions related to fuzzing and code coverage analysis
src/hdmint/wallet.cpp Corrected a typo in the return value description from "sucess" to "success" in CreateMintSeed

In the code where comments dwell,
We fixed the words that didn't spell.
From "deafults" to "defaults" bright,
And "neccessarily" set right.
Now our code is clear and neat,
With every typo faced defeat.
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Outside diff range and nitpick comments (2)
src/fuzz/README.md (2)

Line range hint 136-136: Remove duplicated word for clarity.

- To view the result run run `firefox ./merged-output/index.html`.
+ To view the result run `firefox ./merged-output/index.html`.

Line range hint 139-139: Use "an" instead of "a" before a vowel sound.

- This will start a http server at http://0.0.0.0:8000/
+ This will start an http server at http://0.0.0.0:8000/
Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between cf19353 and b69832f.
Files selected for processing (6)
  • src/crypto/MerkleTreeProof/argon2.h (1 hunks)
  • src/ctpl.h (1 hunks)
  • src/fixed.h (1 hunks)
  • src/fuzz/FuzzedDataProvider.h (1 hunks)
  • src/fuzz/README.md (2 hunks)
  • src/hdmint/wallet.cpp (1 hunks)
Files skipped from review due to trivial changes (5)
  • src/crypto/MerkleTreeProof/argon2.h
  • src/ctpl.h
  • src/fixed.h
  • src/fuzz/FuzzedDataProvider.h
  • src/hdmint/wallet.cpp
Additional Context Used
LanguageTool (10)
src/fuzz/README.md (10)

Near line 24: Possible missing comma found.
Context: ...uzz make sudo make install ``` For more information you can look at https://github.com/goog...


Near line 26: Consider a shorter alternative to avoid wordiness.
Context: ...he following boost and ssl dependencies in order to compile the fuzzing harness: ``` sudo ...


Near line 39: Consider a shorter alternative to avoid wordiness.
Context: ...-dev ``` ### Fuzzing using honggfuzz * In order to fuzz firo/src/libpark using Honggfuzz...


Near line 78: The plural noun “corpora” cannot be used with the article “an”. Did you mean “an empty corpus” or “empty corpora”?
Context: ...p press ctrl+c Here we are providing an empty corpora. In case of an already available corpor...


Near line 132: Possible missing comma found.
Context: ... input_folder as the input corpora from fuzzing or one can also create it by running: `...


Near line 132: ‘preferred to have’ might be wordy. Consider a shorter alternative.
Context: ...ach input inside the input_folder, it's preferred to have only a few inputs, otherwise it will ta...


Near line 132: The word “otherwise” is an adverb that can’t be used like a conjunction, and therefore needs to be separated from the sentence.
Context: ...lder, it's preferred to have only a few inputs, otherwise it will take a long time to generate th...


Near line 135: The modal verb ‘will’ requires the verb’s base form.
Context: ...run ./generate_coverage.sh. This will generated a merged output for all the inputs pres...


Near line 136: Possible typo: you repeated a word
Context: ...the input_folder. 5. To view the result run run firefox ./merged-output/index.html. ...


Near line 139: Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’.
Context: ...ython3 -m http.server`. This will start a http server at http://0.0.0.0:8000/ 8. ...

Markdownlint (68)
src/fuzz/README.md (68)

39: Expected: dash; Actual: asterisk
Unordered list style


61: Expected: dash; Actual: asterisk
Unordered list style


118: Expected: dash; Actual: asterisk
Unordered list style


72: Expected: 0 or 2; Actual: 1
Trailing spaces


83: Expected: 0 or 2; Actual: 1
Trailing spaces


99: Expected: 0 or 2; Actual: 1
Trailing spaces


116: Expected: 1; Actual: 2
Multiple consecutive blank lines


3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines


6: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines


15: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines


38: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines


117: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines


8: null
Fenced code blocks should be surrounded by blank lines


10: null
Fenced code blocks should be surrounded by blank lines


17: null
Fenced code blocks should be surrounded by blank lines


23: null
Fenced code blocks should be surrounded by blank lines


54: null
Fenced code blocks should be surrounded by blank lines


56: null
Fenced code blocks should be surrounded by blank lines


64: null
Fenced code blocks should be surrounded by blank lines


66: null
Fenced code blocks should be surrounded by blank lines


68: null
Fenced code blocks should be surrounded by blank lines


84: null
Fenced code blocks should be surrounded by blank lines


89: null
Fenced code blocks should be surrounded by blank lines


96: null
Fenced code blocks should be surrounded by blank lines


98: null
Fenced code blocks should be surrounded by blank lines


100: null
Fenced code blocks should be surrounded by blank lines


105: null
Fenced code blocks should be surrounded by blank lines


107: null
Fenced code blocks should be surrounded by blank lines


109: null
Fenced code blocks should be surrounded by blank lines


111: null
Fenced code blocks should be surrounded by blank lines


119: null
Fenced code blocks should be surrounded by blank lines


128: null
Fenced code blocks should be surrounded by blank lines


7: null
Lists should be surrounded by blank lines


7: null
Lists should be surrounded by blank lines


11: null
Lists should be surrounded by blank lines


16: null
Lists should be surrounded by blank lines


16: null
Lists should be surrounded by blank lines


39: null
Lists should be surrounded by blank lines


63: null
Lists should be surrounded by blank lines


67: null
Lists should be surrounded by blank lines


67: null
Lists should be surrounded by blank lines


73: null
Lists should be surrounded by blank lines


95: null
Lists should be surrounded by blank lines


104: null
Lists should be surrounded by blank lines


118: null
Lists should be surrounded by blank lines


118: null
Lists should be surrounded by blank lines


11: null
Bare URL used


16: null
Bare URL used


24: null
Bare URL used


118: null
Bare URL used


139: null
Bare URL used


140: null
Bare URL used


8: null
Fenced code blocks should have a language specified


17: null
Fenced code blocks should have a language specified


28: null
Fenced code blocks should have a language specified


41: null
Fenced code blocks should have a language specified


49: null
Fenced code blocks should have a language specified


54: null
Fenced code blocks should have a language specified


64: null
Fenced code blocks should have a language specified


68: null
Fenced code blocks should have a language specified


84: null
Fenced code blocks should have a language specified


89: null
Fenced code blocks should have a language specified


96: null
Fenced code blocks should have a language specified


100: null
Fenced code blocks should have a language specified


105: null
Fenced code blocks should have a language specified


109: null
Fenced code blocks should have a language specified


119: null
Fenced code blocks should have a language specified


142: null
Files should end with a single newline character

@@ -129,7 +129,7 @@ sudo make install
Once successfully installed, follow the below instructions to generate the code-coverage

1. First compile the harness with gdb flag. run `make <filename>_debug` inside src/fuzz to compile using gdb debugger.
2. take the input_folder as the input corpora from fuzzing or one can also create it by running: `honggfuzz -i <input_folder> -– ./<filename>_hfuzz ___FILE___ @@`. This will start the fuzzer. Kill it by `ctrl+C`. The fuzzer will generate some random inputs inside the input_folder. Since kcov will generate coverage for each input inside the input_folder, it's preffered to have only a few inputs, otherwise it will take a long time to generate the entire coverage.
2. take the input_folder as the input corpora from fuzzing or one can also create it by running: `honggfuzz -i <input_folder> -– ./<filename>_hfuzz ___FILE___ @@`. This will start the fuzzer. Kill it by `ctrl+C`. The fuzzer will generate some random inputs inside the input_folder. Since kcov will generate coverage for each input inside the input_folder, it's preferred to have only a few inputs, otherwise it will take a long time to generate the entire coverage.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct verb form for consistency and grammatical accuracy.

- This will generated a merged output for all the inputs present in the input_folder.
+ This will generate a merged output for all the inputs present in the input_folder.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
2. take the input_folder as the input corpora from fuzzing or one can also create it by running: `honggfuzz -i <input_folder> -– ./<filename>_hfuzz ___FILE___ @@`. This will start the fuzzer. Kill it by `ctrl+C`. The fuzzer will generate some random inputs inside the input_folder. Since kcov will generate coverage for each input inside the input_folder, it's preferred to have only a few inputs, otherwise it will take a long time to generate the entire coverage.
2. take the input_folder as the input corpora from fuzzing or one can also create it by running: `honggfuzz -i <input_folder> -– ./<filename>_hfuzz ___FILE___ @@`. This will start the fuzzer. Kill it by `ctrl+C`. The fuzzer will generate some random inputs inside the input_folder. Since kcov will generate coverage for each input inside the input_folder, it's preferred to have only a few inputs, otherwise it will take a long time to generate the entire coverage. This will generate a merged output for all the inputs present in the input_folder.

@@ -75,7 +75,7 @@ example:
2. `honggfuzz -i ../input -- ./../libspark/bpplus_hfuzz ___FILE___`
3. To stop press `ctrl+c`

Here we are providing an empty corpora. In case of an already available corpora, we can provide the availabe corpora.
Here we are providing an empty corpora. In case of an already available corpora, we can provide the available corpora.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct grammatical error in the use of "corpora".

- Here we are providing an empty corpora.
+ Here we are providing empty corpora.

Committable suggestion was skipped due low confidence.

@reubenyap reubenyap merged commit 6f5267c into firoorg:master Jun 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants