Get spark output addresses in daemon api

[levonpetrosyan93]

This change allows to get spark output addresses by deamon
Running gettransaction and listtransactions includes also spark addresses.
NOTE, this only works for the wallet on which the tx is created, restored wallet or a wallet running in parallel on another device will work as previously.

[coderabbitai]

Walkthrough

The changes enhance the ListTransactions function in the src/wallet/rpcwallet.cpp file by introducing a new structure, CSparkOutputTx, to manage "Spark transactions." The code now checks for specific transaction output types and retrieves corresponding data to adjust how transaction amounts are displayed. The logic for amount determination has been refined, ensuring that the display reflects the type of transaction processed while maintaining the overall structure of the function.

Changes

File	Change Summary
src/wallet/rpcwallet.cpp	Introduced CSparkOutputTx structure and modified ListTransactions to handle Spark transactions, adjusting amount display logic based on transaction type.

Poem

In the wallet where transactions play,
A Spark shines bright, lighting the way.
With new logic to guide,
Amounts now abide,
A hop towards clarity, come what may! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between db219f3 and 925d31f.

📒 Files selected for processing (1)

• src/wallet/rpcwallet.cpp (2 hunks)

🔇 Additional comments (2)

src/wallet/rpcwallet.cpp (2)

1685-1695: Proper handling of Spark transactions in ListTransactions

The newly added code correctly detects Spark transactions and extracts the associated Spark address, enhancing the functionality of the ListTransactions function as intended.

---

1706-1709: Verify initialization of output.amount before usage

Ensure that output.amount is properly initialized before it is used when output.address is not empty. This will prevent potential issues related to uninitialized variables.

As a follow-up, please confirm that output.amount is always set when output.address is not empty to guarantee safe usage.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.